From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8DHA-0004L2-0G
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:30:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8DH5-0004IO-BF
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:30:19 -0500
Received: from [199.232.76.173] (port=35027 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8DH5-0004IL-3I
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:30:15 -0500
Received: from cantor2.suse.de ([195.135.220.15]:33061 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <hare@suse.de>) id 1N8DH4-0001CE-Nl
	for qemu-devel@nongnu.org; Wed, 11 Nov 2009 08:30:14 -0500
Message-ID: <4AFABC65.7050308@suse.de>
Date: Wed, 11 Nov 2009 14:30:13 +0100
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [sneak preview] major scsi overhaul
References: <4AF4ACA5.2090701@redhat.com>
	<4AFA9E36.3030507@redhat.com>	<4AFAA58B.6090907@suse.de>
	<4AFAB5F8.50209@redhat.com>
In-Reply-To: <4AFAB5F8.50209@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Gerd Hoffmann wrote:
> On 11/11/09 12:52, Hannes Reinecke wrote:
>> I still don't quite agree with the new scsi callback, which has
>> just the SCSIRequest as an argument. So when supporting more command
>> queueing we have no idea to which (internal) request structure
>> the SCSIRequest belongs, and still have to do a lookup.
>> Which is painful. Can we have a second 'void *arg' argument
>> to the callback which will allow us some driver specific
>> pointer?
>=20
> How about sticking a 'void *hba_private' element into SCSIRequest inste=
ad?
>=20
Would work for me, too.

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: Markus Rex, HRB 16746 (AG N=FCrnberg)