From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8J2a-0004ja-M9 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 14:39:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8J2W-0004j7-03 for qemu-devel@nongnu.org; Wed, 11 Nov 2009 14:39:40 -0500 Received: from [199.232.76.173] (port=36603 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8J2V-0004j4-Rr for qemu-devel@nongnu.org; Wed, 11 Nov 2009 14:39:35 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:20042) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8J2V-0006jm-6Z for qemu-devel@nongnu.org; Wed, 11 Nov 2009 14:39:35 -0500 Received: by fg-out-1718.google.com with SMTP id d23so627862fga.10 for ; Wed, 11 Nov 2009 11:39:33 -0800 (PST) Message-ID: <4AFB12F1.5080406@codemonkey.ws> Date: Wed, 11 Nov 2009 13:39:29 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 10/11] Add a QObject JSON wrapper References: <1257960543-26373-1-git-send-email-aliguori@us.ibm.com> <1257960543-26373-10-git-send-email-aliguori@us.ibm.com> <20091111161205.00eac61f@doriath> In-Reply-To: <20091111161205.00eac61f@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , qemu-devel@nongnu.org Luiz Capitulino wrote: > I think we should abort() on error, assuming the only way to fail > is a bad syntax. > We'll be using qobject_from_jsonf() to parse incoming QMP traffic. We definitely don't want to abort when we receive invalid input on the QMP port. Best to just close the session and let the user connect again. Regards, Anthony Liguori