From: Jan Kiszka <jan.kiszka@web.de>
To: Juan Quintela <quintela@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression
Date: Thu, 12 Nov 2009 14:13:06 +0100 [thread overview]
Message-ID: <4AFC09E2.6060404@web.de> (raw)
In-Reply-To: <m3my2rvqww.fsf@neno.mitica>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
Juan Quintela wrote:
> Jan Kiszka <jan.kiszka@web.de> wrote:
>> *** NOTE ***
>> 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only
>> briefly checked the first one, and it looks similar broken. Could
>> someone have a second look at them? Maybe it is also better to define a
>> vmsd opaque in DeviceInfo, which would also allow to solve this issue
>> differently.
>>
>
> I searched for .qdev.vmsd, and all the other uses are right as far as I
> can see.
Maybe it works, but it doesn't look clean to me. E.g. tcx.c,
vmstate_tcx_post_load: it should be called with the DeviceState as
opaque value, right? Then I'm missing container_of(d, TCXState,
busdev.qdev).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-11-12 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 22:53 [Qemu-devel] [PATCH] fdc: Fix vmsave/restore regression Jan Kiszka
2009-11-11 23:28 ` [Qemu-devel] " Juan Quintela
2009-11-12 13:00 ` Juan Quintela
2009-11-12 13:13 ` Jan Kiszka [this message]
2009-11-12 14:37 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFC09E2.6060404@web.de \
--to=jan.kiszka@web.de \
--cc=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).