From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N8ZUI-0003w3-Ix
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 08:13:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N8ZUD-0003rD-6j
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 08:13:21 -0500
Received: from [199.232.76.173] (port=51849 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N8ZUC-0003r2-Qx
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 08:13:16 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:41214)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1N8ZUC-0004vP-Dd
	for qemu-devel@nongnu.org; Thu, 12 Nov 2009 08:13:16 -0500
Message-ID: <4AFC09E2.6060404@web.de>
Date: Thu, 12 Nov 2009 14:13:06 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4AFB4059.8020607@web.de> <m3my2rvqww.fsf@neno.mitica>
In-Reply-To: <m3my2rvqww.fsf@neno.mitica>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig231DF1E5C9CEFE8B100A02A0"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] fdc: Fix vmsave/restore regression
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig231DF1E5C9CEFE8B100A02A0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Juan Quintela wrote:
> Jan Kiszka <jan.kiszka@web.de> wrote:
>> *** NOTE ***
>> 'git shortlog|grep "reset + vmsd"' shows 10 such conversions. I only
>> briefly checked the first one, and it looks similar broken. Could
>> someone have a second look at them? Maybe it is also better to define =
a
>> vmsd opaque in DeviceInfo, which would also allow to solve this issue
>> differently.
>>
>=20
> I searched for .qdev.vmsd, and all the other uses are right as far as I=

> can see.

Maybe it works, but it doesn't look clean to me. E.g. tcx.c,
vmstate_tcx_post_load: it should be called with the DeviceState as
opaque value, right? Then I'm missing container_of(d, TCXState,
busdev.qdev).

Jan


--------------enig231DF1E5C9CEFE8B100A02A0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkr8CegACgkQitSsb3rl5xSu0QCg6ttd5LVz7IiyhSA5uwZQSZ/h
62sAn2Dx7oOc9rYpynjTmdolRWwv7L+N
=t/v5
-----END PGP SIGNATURE-----

--------------enig231DF1E5C9CEFE8B100A02A0--