From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8coT-0003qr-2p for qemu-devel@nongnu.org; Thu, 12 Nov 2009 11:46:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8coO-0003p0-Dv for qemu-devel@nongnu.org; Thu, 12 Nov 2009 11:46:24 -0500 Received: from [199.232.76.173] (port=55885 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8coO-0003ot-9n for qemu-devel@nongnu.org; Thu, 12 Nov 2009 11:46:20 -0500 Received: from qw-out-1920.google.com ([74.125.92.146]:22521) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N8coO-0001kR-02 for qemu-devel@nongnu.org; Thu, 12 Nov 2009 11:46:20 -0500 Received: by qw-out-1920.google.com with SMTP id 5so438620qwc.4 for ; Thu, 12 Nov 2009 08:46:18 -0800 (PST) Message-ID: <4AFC3BCC.9000608@codemonkey.ws> Date: Thu, 12 Nov 2009 10:46:04 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 02/11] Add operations to qlist to allow it to be used as a stack References: <1257960543-26373-1-git-send-email-aliguori@us.ibm.com> <1257960543-26373-2-git-send-email-aliguori@us.ibm.com> <4AFC2AD5.3060606@redhat.com> In-Reply-To: <4AFC2AD5.3060606@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino Kevin Wolf wrote: > Am 11.11.2009 18:28, schrieb Anthony Liguori: > >> This makes lists no longer invariant. It's a very useful bit of functionality >> though. >> >> To deal with the fact that lists are no longer invariant, introduce a deep >> copy mechanism for lists. >> >> Signed-off-by: Anthony Liguori >> --- >> qlist.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> qlist.h | 4 ++++ >> 2 files changed, 60 insertions(+), 0 deletions(-) >> > > So far all functions in qlist.c have a header comment. Any reason to > change this? > But nothing else in qemu does. I don't find this commenting style particularly helpful since they really don't tell you anything you can't infer from the function name. I'm not opposed to people adding these types of comments but I don't think it's a good idea to attempt to enforce it in just this one place (not that I think it should be enforced everywhere). Regards, Anthony Liguori > Kevin > > >