From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N8dF5-0007sK-Aj for qemu-devel@nongnu.org; Thu, 12 Nov 2009 12:13:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N8dF0-0007mO-CF for qemu-devel@nongnu.org; Thu, 12 Nov 2009 12:13:54 -0500 Received: from [199.232.76.173] (port=39216 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N8dF0-0007mE-8i for qemu-devel@nongnu.org; Thu, 12 Nov 2009 12:13:50 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:47426) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N8dEz-0006as-Vi for qemu-devel@nongnu.org; Thu, 12 Nov 2009 12:13:50 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e8.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id nACD9tMY013891 for ; Thu, 12 Nov 2009 08:09:55 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id nACHDmgC055762 for ; Thu, 12 Nov 2009 12:13:48 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nACD8Sf3032237 for ; Thu, 12 Nov 2009 08:08:28 -0500 Message-ID: <4AFC4249.8020702@linux.vnet.ibm.com> Date: Thu, 12 Nov 2009 11:13:45 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 02/11] Add operations to qlist to allow it to be used as a stack References: <1257960543-26373-1-git-send-email-aliguori@us.ibm.com> <1257960543-26373-2-git-send-email-aliguori@us.ibm.com> <4AFC2AD5.3060606@redhat.com> <4AFC3BCC.9000608@codemonkey.ws> <4AFC3E2D.4050002@redhat.com> In-Reply-To: <4AFC3E2D.4050002@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Anthony Liguori , qemu-devel@nongnu.org, Luiz Capitulino Kevin Wolf wrote: > Unfortunately. There are places where such comments could be a good > specification on what an interface is actually meant to work like > (particularly in error cases). Currently you often can't tell if the > implementation or the caller of a function is buggy. > > Not sure if they are really useful for the simple qlist.c functions (but > even there the function name does not tell me what it's doing with NULL > parameters), but it might be helpful to have a general discussion about > it. I think in general qemu is poorly commented. > I agree, but I don't think the solution is forcing boiler plate commenting styles. I think what we could improve on is asking people to comment bits of code during review. > Kevin > -- Regards, Anthony Liguori