qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Don't leak file descriptors
Date: Mon, 16 Nov 2009 18:46:30 +0200	[thread overview]
Message-ID: <4B0181E6.5090207@redhat.com> (raw)
In-Reply-To: <f43fc5580911160821n3ee3780dx38ad25ab7b33af83@mail.gmail.com>

On 11/16/2009 06:21 PM, Blue Swirl wrote:
>
>> How exactly would you do that? The only way I see to do it would be
>> using void*, but I'm not sure if this really is an improvement.
>>      
> Instead of sockaddr_in vs. sockaddr and the lame casts in between, we
> could have QSockAddr which magically works.

Probably a bunch of work for something that is rarely used.

> Or if we only ever use
> sockaddr_in, just use that.
>    

There's some ipv6 support in qemu-sockets.c.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2009-11-16 16:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 15:17 [Qemu-devel] [PATCH] Don't leak file descriptors Kevin Wolf
2009-11-13 15:36 ` Scott Tsai
2009-11-16  2:15   ` Jamie Lokier
2009-11-13 15:41 ` Nathan Froyd
2009-11-13 15:44   ` Kevin Wolf
2009-11-13 21:05 ` Blue Swirl
2009-11-16 12:47   ` Kevin Wolf
2009-11-16 16:21     ` Blue Swirl
2009-11-16 16:46       ` Avi Kivity [this message]
2009-11-16 23:05       ` Jamie Lokier
2009-11-16 23:10         ` Jamie Lokier
2009-11-17  9:12         ` Kevin Wolf
2009-11-17 20:28           ` Blue Swirl
2009-11-16 23:26 ` Anthony Liguori
2009-11-16 23:44   ` Jamie Lokier
2009-11-17  9:00   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0181E6.5090207@redhat.com \
    --to=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).