From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NA4it-0003io-Dt for qemu-devel@nongnu.org; Mon, 16 Nov 2009 11:46:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NA4io-0003fF-Kz for qemu-devel@nongnu.org; Mon, 16 Nov 2009 11:46:38 -0500 Received: from [199.232.76.173] (port=56014 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NA4io-0003fB-Hl for qemu-devel@nongnu.org; Mon, 16 Nov 2009 11:46:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51661) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NA4io-0002Bt-0b for qemu-devel@nongnu.org; Mon, 16 Nov 2009 11:46:34 -0500 Message-ID: <4B0181E6.5090207@redhat.com> Date: Mon, 16 Nov 2009 18:46:30 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Don't leak file descriptors References: <1258125436-23759-1-git-send-email-kwolf@redhat.com> <4B0149C8.7040203@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Kevin Wolf , qemu-devel@nongnu.org On 11/16/2009 06:21 PM, Blue Swirl wrote: > >> How exactly would you do that? The only way I see to do it would be >> using void*, but I'm not sure if this really is an improvement. >> > Instead of sockaddr_in vs. sockaddr and the lame casts in between, we > could have QSockAddr which magically works. Probably a bunch of work for something that is rarely used. > Or if we only ever use > sockaddr_in, just use that. > There's some ipv6 support in qemu-sockets.c. -- error compiling committee.c: too many arguments to function