From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NALxi-0001JJ-UR for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:11:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NALxg-0001IL-Ba for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:11:05 -0500 Received: from [199.232.76.173] (port=42480 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NALxg-0001IH-3a for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:11:04 -0500 Received: from bhuna.collabora.co.uk ([93.93.128.226]:58414) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NALxf-00076X-Ng for qemu-devel@nongnu.org; Tue, 17 Nov 2009 06:11:03 -0500 Message-ID: <4B0284A8.5050800@collabora.co.uk> Date: Tue, 17 Nov 2009 11:10:32 +0000 From: Ian Molton MIME-Version: 1.0 Subject: Re: [Qemu-devel] virtio-rng References: <4AFB2D4D.8050208@collabora.co.uk> <4B011F38.9070500@redhat.com> <4B014584.6000001@collabora.co.uk> <4B014F2D.3040205@redhat.com> <4B0192BE.4010105@collabora.co.uk> <20091117092053.GA10556@amit-x200.redhat.com> <4B02705A.5060400@collabora.co.uk> <20091117095456.GA11125@amit-x200.redhat.com> <4B0278B0.1080505@collabora.co.uk> <20091117102837.GA11493@amit-x200.redhat.com> In-Reply-To: <20091117102837.GA11493@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Amit Shah wrote: > (Any reason to take this off-list?) None other than hitting reply rather than reply-all. CCing list once more :-) >> Either way, you still need to specify the properties - they've just >> moved into the console driver in your patch by the look of it. > > Yeah; there are two ways of setting properties -- from the command line > or from code. > > What you're doing is something like > > -virtiorng,a=foo,b=bar Ah, I see why we're at cross purposes here - I thought we'd moved to discussing virtio-console. I've already moved to qdev based init for virtio-rng - 'fixing' virtio-console was where I learnt about the 'new way' (qdev). >> I'd prefer to do the same for virtio-rng, Here I refer to you having (and I didnt apply the patch so I may have misread) dropped the virtio-pci proxy from virtio-console. Once I've got a tree I can apply your patch to I'll take another look :-) > You should work on the qemu.git tree (use -enable-kvm for testing :). > KVM will get the changes automatically when your changes get merged in > qemu and the kvm maintainers next merge the qemu git repo. I'll do that then ;-) >> Yes, I saw that. Would it not be better to generate the device / chardev >> pair dynamically though, rather than preserve the icky old array? > > I don't understand what you mean by 'dynamically'. Rather than have that array virtcon_hds at all, create the pairs of host side data and qdev properties during parsing the commandline - no need to store them up and iterate through the later, or to set an arbitrary limit on how many can be specified in that way. Might be an idea for qemu to warn people that this syntax will be deprecated, too... -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJLAoSmAAoJEFIjE1w7L6YHcq4P/jlzcNvWHqqkRQkdQWsy6JUh Kh3LDh23nuK9u+aoFgXP8gpej8jT6+cAdzQ+opk/JnPQXDW4nSWcdN5HKPAmTKMP +N78mx7w0WAOFPXd33ZRvP9mqIir6wPmwibC1aUyk6Q6+KH9Io+IDvH6qfrkIung mYHL3WSDObkcHa6+F1ADxYA9TWr9eib6lOu8EG4LgSeJRq48+2b++kvhd8mFcMdg yu1ed7V0U43rMhbIrAtlQsp3BWlF3KdrciFtlXyLJ9iBeSp8H0IUn+XWt1nqvNdP T47J6Weiv7wap2RqSj7Pf5xFs45zyw2ismsfmR9iMraanISF+laZSoBynT/Et7eg d8BoEE/PGsYeFcRm1cpETPkO7fRQxXmd8To6IqomWmT0r41KcEW9Bcs7/MIZcPpo LtH3jZqbsd5vLEIf769rs3g38gmkNpq3sfDMJ+a5xRW9qdVOmeWfD4bPpqwIPYrq MRF/YSZch+aLsKx7Ql+CxM+r/xY7HscIS/4hfIC8OzKnEOxO+jGiV4Mf9RMfOBZw DdXv9YKeu3gemhguKo4NEoTonmvcv6PvhVplu5T4+wJCMjI0T2QkaJmNQFqQSfQj FB+Qri0ad8GY5H6eirvXq/6qBHtuMP+9fJn0A/ErvlXTBKYJg+VeBQSraSylOy4c ii9UNqk7klAw4lN7hnuP =af4Q -----END PGP SIGNATURE-----