From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NANRh-0002H5-E3 for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:46:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NANRc-0002Dq-4H for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:46:08 -0500 Received: from [199.232.76.173] (port=56242 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NANRb-0002Da-Oi for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:46:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57364) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NANRb-000521-9C for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:46:03 -0500 Message-ID: <4B029B00.5010105@redhat.com> Date: Tue, 17 Nov 2009 13:45:52 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest. References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> <1258453071-3496-6-git-send-email-kraxel@redhat.com> <200911171155.37272.paul@codesourcery.com> In-Reply-To: <200911171155.37272.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 11/17/09 12:55, Paul Brook wrote: >> move scsi command from SCSIGenericReq to SCSIRequest. > > Why? AFAICS This has precisely one user, and more importantly it is not > populated by scsi-disk.c. Next patch of scsi patches will make scsi-disk use it too. (in the git tree: a bunch of patches prefixed "scsi-disk: "). cheers, Gerd