From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NANXG-0005Nt-GW
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:51:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NANXB-0005Lp-LR
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:51:53 -0500
Received: from [199.232.76.173] (port=55251 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NANXB-0005Lk-Do
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:51:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57341)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NANXA-0005t4-UZ
	for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:51:49 -0500
Message-ID: <4B029C51.6070603@redhat.com>
Date: Tue, 17 Nov 2009 13:51:29 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into
	generic code.
References: <1258453071-3496-1-git-send-email-kraxel@redhat.com>
	<1258453071-3496-10-git-send-email-kraxel@redhat.com>
	<20091117115047.GA1330@lst.de>
	<200911171227.56645.paul@codesourcery.com>
In-Reply-To: <200911171227.56645.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 11/17/09 13:27, Paul Brook wrote:
> On Tuesday 17 November 2009, Christoph Hellwig wrote:
>> The subject is a bit confusing - it's not the full request parsing but
>> just some helpers.
>
> This is a good example of a patch with an insufficient commit message.
> Given the way GIT treats the first line of the commit mesaage, my advice is to
> make both the subject and the body of the commit message independent.
>
> On a more technical note, why aren't you also using this function in scsi-
> disc.c? Surely that's the whole point of moving it into common code.

Same as with the command move: next patch series will rework scsi-disk 
to put the new fields and functions into use.

cheers,
   Gerd