From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NANc3-0006xs-WC for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:56:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NANbz-0006vk-2A for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:56:51 -0500 Received: from [199.232.76.173] (port=59884 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NANby-0006ve-UP for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:56:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11311) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NANby-0006ej-Bm for qemu-devel@nongnu.org; Tue, 17 Nov 2009 07:56:46 -0500 Message-ID: <4B029D83.5070500@redhat.com> Date: Tue, 17 Nov 2009 13:56:35 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 15/15] scsi: add scsi_req_print() References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> <1258453071-3496-16-git-send-email-kraxel@redhat.com> <20091117120231.GC2288@lst.de> In-Reply-To: <20091117120231.GC2288@lst.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org On 11/17/09 13:02, Christoph Hellwig wrote: > On Tue, Nov 17, 2009 at 11:17:51AM +0100, Gerd Hoffmann wrote: >> Handy for debugging. > > Yes, nice one, but what about getting rid of the ad-hoc printfs in > scsi-disk, too? Will be part of the next scsi patch series which reworks scsi-disk.c cheers, Gerd