From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NARGz-0004b2-Bd for qemu-devel@nongnu.org; Tue, 17 Nov 2009 11:51:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NARGu-0004YB-F3 for qemu-devel@nongnu.org; Tue, 17 Nov 2009 11:51:20 -0500 Received: from [199.232.76.173] (port=38537 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NARGu-0004Xt-8Y for qemu-devel@nongnu.org; Tue, 17 Nov 2009 11:51:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2313) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NARGt-00031Y-AO for qemu-devel@nongnu.org; Tue, 17 Nov 2009 11:51:15 -0500 Message-ID: <4B02D475.6040700@redhat.com> Date: Tue, 17 Nov 2009 17:51:01 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] OPT_SIZE parsing References: <4B029916.6000809@collabora.co.uk> <200911171324.15230.paul@codesourcery.com> <4B02B1EF.70206@collabora.co.uk> In-Reply-To: <4B02B1EF.70206@collabora.co.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Molton Cc: Paul Brook , qemu-devel@nongnu.org On 11/17/09 15:23, Ian Molton wrote: > I've cooked up this patch (attached) to add a SIZE property to qdevs. > I've kept the same semantics as the OPT_SIZE parser for now. The error message should be adapted (s/Option/Property/ at least). Maybe also create a common function for parsing called by both parse_size() and parse_option_size() to make sure OPT_SIZE and the new size property accept the same syntax? Otherwise it looks fine to me. cheers, Gerd