From: Ian Molton <ian.molton@collabora.co.uk>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] OPT_SIZE parsing
Date: Tue, 17 Nov 2009 18:11:18 +0000 [thread overview]
Message-ID: <4B02E746.2050007@collabora.co.uk> (raw)
In-Reply-To: <4B02D475.6040700@redhat.com>
Gerd Hoffmann wrote:
> On 11/17/09 15:23, Ian Molton wrote:
>> I've cooked up this patch (attached) to add a SIZE property to qdevs.
>> I've kept the same semantics as the OPT_SIZE parser for now.
>
> The error message should be adapted (s/Option/Property/ at least).
Fixed locally.
> Maybe also create a common function for parsing called by both
> parse_size() and parse_option_size() to make sure OPT_SIZE and the new
> size property accept the same syntax?
The thought crossed my mind, but then I thought that as none of the
other parsers share common code (yet), it didn't make sense.
I can cook up another patch that allows the option parser to hook into
the property parsing functions, or vice-versa, if you like?
> Otherwise it looks fine to me.
Cool - whats the submission procedure? I can make a git branch publicly
available or I can send patches to someone...
-Ian
next prev parent reply other threads:[~2009-11-17 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 12:37 [Qemu-devel] OPT_SIZE parsing Ian Molton
2009-11-17 13:24 ` Paul Brook
2009-11-17 14:23 ` Ian Molton
2009-11-17 16:51 ` Gerd Hoffmann
2009-11-17 18:11 ` Ian Molton [this message]
2009-11-17 19:19 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B02E746.2050007@collabora.co.uk \
--to=ian.molton@collabora.co.uk \
--cc=kraxel@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).