From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAh64-0003Nl-5o for qemu-devel@nongnu.org; Wed, 18 Nov 2009 04:45:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAh5y-0003Lg-Uo for qemu-devel@nongnu.org; Wed, 18 Nov 2009 04:45:07 -0500 Received: from [199.232.76.173] (port=45086 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAh5y-0003La-Ku for qemu-devel@nongnu.org; Wed, 18 Nov 2009 04:45:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12554) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAh5y-0004CW-5p for qemu-devel@nongnu.org; Wed, 18 Nov 2009 04:45:02 -0500 Message-ID: <4B03C210.1070005@redhat.com> Date: Wed, 18 Nov 2009 10:44:48 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ. References: <1258453071-3496-1-git-send-email-kraxel@redhat.com> <1258453071-3496-4-git-send-email-kraxel@redhat.com> <200911171159.54656.paul@codesourcery.com> <4B02998A.5000409@redhat.com> In-Reply-To: <4B02998A.5000409@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org On 11/17/09 13:39, Gerd Hoffmann wrote: > Isn't that easy because scsi-disk and scsi-generic keep a pool of unused > request structures. I didn't change that for now, although I've > considered dropping it. Not sure how important it is these days, malloc > implementations don't do slow+stupid list walks any more ... No strong objections -> I'll go zap the pools and move more bits into common code. cheers, Gerd