From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAmD1-0007OI-7b for qemu-devel@nongnu.org; Wed, 18 Nov 2009 10:12:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAmCw-0007Lk-1Z for qemu-devel@nongnu.org; Wed, 18 Nov 2009 10:12:38 -0500 Received: from [199.232.76.173] (port=47245 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAmCv-0007Ld-PP for qemu-devel@nongnu.org; Wed, 18 Nov 2009 10:12:33 -0500 Received: from mx20.gnu.org ([199.232.41.8]:29441) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NAmCv-0004Lg-4V for qemu-devel@nongnu.org; Wed, 18 Nov 2009 10:12:33 -0500 Received: from cantor.suse.de ([195.135.220.2] helo=mx1.suse.de) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NAmCt-0007Td-Pm for qemu-devel@nongnu.org; Wed, 18 Nov 2009 10:12:32 -0500 Message-ID: <4B040EDB.9040503@suse.de> Date: Wed, 18 Nov 2009 16:12:27 +0100 From: Alexander Graf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap References: <20091118140207.GB31670@os.inf.tu-dresden.de> <4B0405A6.5080706@suse.de> <20091118145332.GE31670@os.inf.tu-dresden.de> In-Reply-To: <20091118145332.GE31670@os.inf.tu-dresden.de> Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Lackorzynski Cc: Anthony Liguori , qemu-devel@nongnu.org Adam Lackorzynski wrote: > On Wed Nov 18, 2009 at 15:33:10 +0100, Alexander Graf wrote: > >> Adam Lackorzynski wrote: >> >>> I need to following to fix multiboot booting for me. >>> >>> Should linuxboot.bin and multiboot.bin end up in pc-bios instead of >>> pc-bios/optionrom? >>> >>> load_image(initrd_filename, >>> mb_kernel_data + mb_mod_start - mh_load_addr); >>> >>> @@ -720,7 +720,7 @@ static int load_multiboot(void *fw_cfg, >>> fw_cfg_add_bytes(fw_cfg, FW_CFG_INITRD_DATA, mb_bootinfo_data, >>> sizeof(bootinfo)); >>> >>> - option_rom[nb_option_roms] = "multiboot.bin"; >>> + option_rom[nb_option_roms] = "optionrom/multiboot.bin"; >>> >>> >> This is wrong. The .bin file should be in pc-bios. It just doesn't get >> copied over as part of the build process, but instead relies on the >> committer to make sure the binary is updated on every source change. >> > > Ok, didn't know. Thank you both for clarifying! New patch attached. > > > Signed-off-by: Adam Lackorzynski > Acked-by: Alexander Graf Alex