From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAqfr-0000ud-Ca for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:58:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAqfl-0000ru-Ln for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:58:42 -0500 Received: from [199.232.76.173] (port=47354 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAqfl-0000rr-IH for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:58:37 -0500 Received: from e32.co.us.ibm.com ([32.97.110.150]:49718) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NAqfl-0007So-22 for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:58:37 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e32.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id nAIJrDHD012633 for ; Wed, 18 Nov 2009 12:53:13 -0700 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id nAIJwMN5237400 for ; Wed, 18 Nov 2009 12:58:23 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id nAIDqJSR012294 for ; Wed, 18 Nov 2009 06:52:19 -0700 Message-ID: <4B0451D9.9080505@linux.vnet.ibm.com> Date: Wed, 18 Nov 2009 13:58:17 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 07/10] Introduce QError References: <1258487037-24950-1-git-send-email-lcapitulino@redhat.com> <1258487037-24950-8-git-send-email-lcapitulino@redhat.com> <20091118181456.GA29178@redhat.com> In-Reply-To: <20091118181456.GA29178@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: armbru@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino Daniel P. Berrange wrote: > On Tue, Nov 17, 2009 at 05:43:54PM -0200, Luiz Capitulino wrote: > >> QError is a high-level data type which represents an exception >> in QEMU, it stores the following error information: >> >> - class Error class name (eg. "ServiceUnavailable") >> - description A detailed error description, which can contain >> references to run-time error data >> - filename The file name of where the error occurred >> - line number The exact line number of the error >> > > If we're going to collect these two, then also add in the function > name, since that's typically more useful than filename/line number > alone. > I'm not convinced it's a good idea to put that info on the wire. It's unstable across any build of qemu. However, since it's extra info, it doesn't bother me that much if people think it's useful for debugging purposes. > Regards, > Daniel > -- Regards, Anthony Liguori