From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NB6kW-0002GJ-ST for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:08:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NB6kV-0002Fh-GH for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:08:36 -0500 Received: from [199.232.76.173] (port=58256 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NB6kV-0002FV-Ay for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:08:35 -0500 Received: from hall.aurel32.net ([88.191.82.174]:37903) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NB6kU-0001Ei-UJ for qemu-devel@nongnu.org; Thu, 19 Nov 2009 08:08:35 -0500 Message-ID: <4B054343.3040107@aurel32.net> Date: Thu, 19 Nov 2009 14:08:19 +0100 From: Aurelien Jarno MIME-Version: 1.0 Subject: Re: [Qemu-devel] [BUG] Changing SDL full screen mode no longer works References: <4B0450C7.70708@mail.berlios.de> <4B04FA73.60003@mail.berlios.de> In-Reply-To: <4B04FA73.60003@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Stefano Stabellini , aurel32@debian.org, qemu-devel@nongnu.org Stefan Weil a écrit : > Stefan Weil schrieb: >> Stefano Stabellini schrieb: >>> Hi all, >>> currently vga always resizes the screen when vga_hw_invalidate is called >>> while this is not required and all the other graphic emulators don't. >>> This patch fixes it, making vga invalidate behaviour consistent with the >>> other emulated devices. >>> >>> Signed-off-by: Stefano Stabellini >> This rather old patch breaks switching to and from full screen mode >> using SDL and alt-ctrl-f key. >> >> Please revert or fix it. The patch is also part of stable-0.11, so I >> expect the same problem there (but did not test it). >> >> Found by git bisect, tested on several linux installations. >> > > Debian qemu 0.11.0-5 is suffering from this bug, too. > > So 0bd8246bfec1dfb2eb959f52db535572c0260f4c > should be reverted or fixed not only for master but > also for stable-0.11. > Before reverting that into stable-0.11, we should take time to understand the problem and have a correct fix (which might be a revert). -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net