From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NB9dv-0004ju-5g
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:13:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NB9dq-0004f5-LB
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:13:58 -0500
Received: from [199.232.76.173] (port=40059 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NB9dq-0004es-9n
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:13:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:4185)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NB9dp-0005DI-ST
	for qemu-devel@nongnu.org; Thu, 19 Nov 2009 11:13:54 -0500
Message-ID: <4B056EB8.9020509@redhat.com>
Date: Thu, 19 Nov 2009 18:13:44 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1258643169.3464.3.camel@aglitke>	
	<1258643945.3464.5.camel@aglitke> <4B0562A0.7040507@redhat.com>
	<1258646331.3464.18.camel@aglitke>
In-Reply-To: <1258646331.3464.18.camel@aglitke>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the
 balloon driver (V3)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, Anthony Liguori <aliguori@us.ibm.com>, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org

On 11/19/2009 05:58 PM, Adam Litke wrote:
> On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
>    
>> On 11/19/2009 05:19 PM, Adam Litke wrote:
>>      
>>> Rusty and Anthony,
>>> If I've addressed all outstanding issues, please consider this patch for
>>> inclusion.  Thanks.
>>>
>>> +struct virtio_balloon_stat
>>> +{
>>> +	__le16 tag;
>>> +	__le64 val;
>>> +};
>>> +
>>>
>>>        
>> You're not doing endian conversion in the host?
>>      
> No.  I was following by example.  For the virtio_balloon, the existing
> code is careful so that the guest always writes data in little endian.
>    

I don't follow.  If the guest is careful to write little-endian, surely 
the host must be equally careful to read little-endian?

-- 
error compiling committee.c: too many arguments to function