From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCEvJ-0005gQ-Ci
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 11:04:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCEvE-0005fW-KY
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 11:04:24 -0500
Received: from [199.232.76.173] (port=57695 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCEvE-0005fT-FY
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 11:04:20 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:52560)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NCEvD-0004j2-F1
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 11:04:20 -0500
Received: by yxe26 with SMTP id 26so4003963yxe.4
	for <qemu-devel@nongnu.org>; Sun, 22 Nov 2009 08:04:19 -0800 (PST)
Message-ID: <4B0960FF.9030409@codemonkey.ws>
Date: Sun, 22 Nov 2009 10:04:15 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RFC v0 00/15] QEMU Monitor Protocol
References: <1258643623-8636-1-git-send-email-lcapitulino@redhat.com>	<4B05623E.5080903@redhat.com>
	<20091119144708.6e00306b@doriath>	<4B09072E.4090206@redhat.com>
	<20091122130215.5021843b@doriath>
In-Reply-To: <20091122130215.5021843b@doriath>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

Luiz Capitulino wrote:
>>> { "execute": "info", "arguments": { "item": "balloon" } }
>>> {"return": 512}
>>>
>>> { "execute": "info", "arguments": { "item": "network" } }
>>> {"return": [{"devices": [{"name": "user.0", "info": "net=10.0.2.0, restricted=n"}, {"name": "e1000.0", "info": "model=e1000,macaddr=52:54:00:12:34:56"}], "id": 0}]}
>>>    
>>>       
>> The internal "info" is very worrying.  We need to make sure everything 
>> is returned as an object without the need for additional parsing.
>>     
>
>  That's the complicated part.
>
>  Some (several?) Monitor commands would require deeper changes to return
> 100% of their information in QObject style.
>
>  This takes time for me, as I have to dig in subsystems I'm not so
> familiar with and have to work on the other series too.
>
>  So, I've chosen to do the easy conversion now so that the project
> goes forward. I know this can compromise protocol stability, but I was
> planning not to declare the protocol stable for 0.12.
>
>  This is a discussion we should have.
>   

We should not partially convert commands. IOW, if there still is an 
"info" output, the command is not converted and should not be exposed in 
the protocol.

I'm okay with only exposing a few functions in QMP, but I don't want to 
expose functions whose output is either not well formed or partially 
converted.

Regards,

Anthony Liguori