From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCIa6-0001C6-0D
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 14:58:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCIa1-0001B3-C8
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 14:58:45 -0500
Received: from [199.232.76.173] (port=46509 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCIa1-0001B0-73
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 14:58:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22018)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <ykaul@redhat.com>) id 1NCIa0-0005En-JY
	for qemu-devel@nongnu.org; Sun, 22 Nov 2009 14:58:40 -0500
Message-ID: <4B0997E9.4040505@redhat.com>
Date: Sun, 22 Nov 2009 21:58:33 +0200
From: Yaniv Kaul <ykaul@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP
	test
References: <20091122140853.GI3193@redhat.com>	<A3736408F685471D9D2D3864DE814A86@FSCPC>	<20091122172101.GB9880@redhat.com>
	<38AF5F086DB24529A1D605A0E2414FD0@FSCPC>
In-Reply-To: <38AF5F086DB24529A1D605A0E2414FD0@FSCPC>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: kevin@koconnor.net, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

On 11/22/2009 7:39 PM, Sebastian Herbszt wrote:


<SNIP>
>>>
>>> >/* Type 16 -- Physical Memory Array */
>>> >@@ -239,7 +240,7 @@ smbios_init_type_16(void *start, u32 
>>> memory_size_mb, int nr_mem_devs)
>>> >
>>> >    p->location = 0x01; /* other */
>>> >    p->use = 0x03; /* system memory */
>>> >-    p->error_correction = 0x01; /* other */
>>> >+    p->error_correction = 0x06; /* Multi-bit ECC to make Microsoft 
>>> happy */
>>> >    p->maximum_capacity = memory_size_mb * 1024;
>>> >    p->memory_error_information_handle = 0xfffe; /* none provided */
>>> >    p->number_of_memory_devices = nr_mem_devs;
>>>
>>> Does it happen to work with "Unknown" or "None"?
>>>
>> No. They explicitly request single or multi-bit ECC. Though I was told
>> that Microsoft gives exception for this requirement.
>
> Odd. Why do they care whether the VM reports (non existent) error 
> correction support.


The test probably does not realize it's a VM and SVVP runs the 2008R2 
system tests - which requires ECC memory (and PCI express bus for 
network and block devices, but that's another exception).
Y.

>
>> -- 
>> Gleb.
>
> - Sebastian
>
>
>