From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCMJ2-0004HH-40 for qemu-devel@nongnu.org; Sun, 22 Nov 2009 18:57:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCMIx-0004BU-Du for qemu-devel@nongnu.org; Sun, 22 Nov 2009 18:57:23 -0500 Received: from [199.232.76.173] (port=55988 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCMIx-0004BG-3y for qemu-devel@nongnu.org; Sun, 22 Nov 2009 18:57:19 -0500 Received: from mail.gmx.net ([213.165.64.20]:37345) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1NCMIw-0004Lt-Ew for qemu-devel@nongnu.org; Sun, 22 Nov 2009 18:57:18 -0500 Message-ID: <4B09CFDA.80705@gmx.net> Date: Mon, 23 Nov 2009 00:57:14 +0100 From: Carl-Daniel Hailfinger MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test References: <20091122140853.GI3193@redhat.com> <20091122172101.GB9880@redhat.com> <38AF5F086DB24529A1D605A0E2414FD0@FSCPC> In-Reply-To: <38AF5F086DB24529A1D605A0E2414FD0@FSCPC> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Herbszt Cc: kevin@koconnor.net, qemu-devel@nongnu.org, Gleb Natapov On 22.11.2009 18:39, Sebastian Herbszt wrote: > Gleb Natapov wrote: >> On Sun, Nov 22, 2009 at 05:51:41PM +0100, Sebastian Herbszt wrote: >>> Is the requirement for "Targeted Content Delivery" specified >>> somewhere with something more >>> clear than "SMBIOS data is useful in identifying the computer for >>> targeted delivery of >>> model-specific software and firmware content" (e.g. changing BIOS >>> version, release date, etc.)? >>> >>> >@@ -130,8 +131,8 @@ smbios_init_type_1(void *start) >>> > p->header.length = sizeof(struct smbios_type_1); >>> > p->header.handle = 0x100; >>> > >>> >- load_str_field_or_skip(1, manufacturer_str); >>> >- load_str_field_or_skip(1, product_name_str); >>> >+ load_str_field_with_default(1, manufacturer_str, "QEMU"); >>> >+ load_str_field_with_default(1, product_name_str, "QEMU"); >>> >>> Use "QEMU Virtual Platform" product name derivated from "VMware >>> Virtual Platform" ? >>> Use "QEMU Project" or "QEMU Community" throughout for manufacturer >>> name? >> I'll change this to use defines as per Kevin's request, so to keep >> number of defines to minimum >> lets make it "QEMU Project" everywhere. > > Will you introduce something like CONFIG_SYSVENDOR? Would be useful in > case some other project > (Bochs, Xen?) starts to use seabios. coreboot already uses SeaBIOS on various x86 hardware platforms. Regards, Carl-Daniel -- Developer quote of the month: "We are juggling too many chainsaws and flaming arrows and tigers."