From: Gerd Hoffmann <kraxel@redhat.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: qemu-devel@nongnu.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9)
Date: Wed, 25 Nov 2009 23:54:06 +0100 [thread overview]
Message-ID: <4B0DB58E.1020203@redhat.com> (raw)
In-Reply-To: <4B0DB041.4060209@linux.intel.com>
On 11/25/09 23:31, H. Peter Anvin wrote:
> On 11/25/2009 02:26 PM, H. Peter Anvin wrote:
>>
>> As such, I think there is still a place for the simple command line
>> options like "-hda", "-serial" and my proposed "-debugcon", in addition
>> to the full-featured connect-anything options and configuration files.
>> That's all.
>>
>
> I guess one question is if the simplified options could be better
> implemented via some kind of builtin macros or translation submodule
> rather than being treated as first-class options which they basically
> are now. Still, that's a future development task.
Wouldn't be that hard I think. Something along the lines of
case QEMU_OPTION_debugcon:
opts = qemu_chr_parse_compat("debugcon", optarg);
if (NULL == opts) {
fprintf(stderr, "already have a debugcon chardev\");
exit(1);
}
opts = qemu_opts_create(&qemu_device_opts, "debugcon", 1);
if (NULL == opts) {
fprintf(stderr, "already have a debugcon device\");
exit(1);
}
qemu_opt_set(opts, "driver", isa-debugcon);
qemu_opt_set(opts, "chardev", "debugcon");
break;
should do the trick. Depends on the chardev fix mentioned in this
thread too. Allows to define a single device with the default port via
shortcut.
I tend to not add new command line switches for every little new device.
For this one it might be reasonable nevertheless given the use cases.
cheers,
Gerd
next prev parent reply other threads:[~2009-11-25 22:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 21:33 [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs port 0xe9) H. Peter Anvin
2009-11-22 17:16 ` [Qemu-devel] Re: [PATCH] debugcon: support for debugging consoles (e.g.Bochs " Sebastian Herbszt
2009-11-23 3:13 ` H. Peter Anvin
2009-11-23 10:52 ` [Qemu-devel] [PATCH] debugcon: support for debugging consoles (e.g. Bochs " Gerd Hoffmann
2009-11-23 20:11 ` H. Peter Anvin
2009-11-24 23:05 ` H. Peter Anvin
2009-11-25 7:33 ` Alexander Graf
2009-11-25 12:46 ` Gerd Hoffmann
2009-11-25 18:01 ` H. Peter Anvin
2009-11-25 22:21 ` Gerd Hoffmann
2009-11-25 22:26 ` H. Peter Anvin
2009-11-25 22:31 ` H. Peter Anvin
2009-11-25 22:54 ` Gerd Hoffmann [this message]
2009-11-26 9:56 ` Markus Armbruster
2009-11-26 13:18 ` [Qemu-devel] " Paolo Bonzini
2009-11-25 22:53 ` [Qemu-devel] " H. Peter Anvin
2009-11-26 7:43 ` [Qemu-devel] " Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2009-12-03 3:11 [Qemu-devel] " H. Peter Anvin
2009-12-03 4:02 ` malc
2009-12-03 5:04 H. Peter Anvin
[not found] <1262123496-12007-1-git-send-email-hpa@linux.intel.com>
[not found] ` <20091230164946.GA9858@morn.localdomain>
2010-01-02 3:01 ` H. Peter Anvin
2010-01-02 3:02 ` H. Peter Anvin
2010-01-02 17:53 ` Kevin O'Connor
2010-01-02 18:56 ` H. Peter Anvin
2010-01-03 2:13 ` François Revol
2010-01-08 16:36 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0DB58E.1020203@redhat.com \
--to=kraxel@redhat.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).