qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: Juan Quintela <quintela@trasno.org>
Cc: Paul Brook <paul@codesourcery.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] Makefile: Add missing rule for config-devices.mak
Date: Thu, 26 Nov 2009 11:25:48 +0100	[thread overview]
Message-ID: <4B0E57AC.5090401@mail.berlios.de> (raw)
In-Reply-To: <m33a45ia0a.fsf@neno.neno>

Juan Quintela schrieb:
> Stefan Weil <weil@mail.berlios.de> wrote:
>> All files config-devices.mak are copies from files in
>> directory default-configs.
>>
>> Creating these copies during configuration ignores these
>> dependencies and may result in unresolved externals
>> from incremental builds when files in default-configs
>> are modified.
>>
>> By adding a dependency rule to Makefile and executing
>> the copy commands there it is possible to run incremental
>> builds even with modified default-configs.
>
> But then, if you have modified the file, you lost your changes.
> That file is not overwrote on purpose. Think of it as the .config when
> you compile your kernel. If you don't have one, it gets a default one.
> But if you have one, it will not overwrote it. Not all devices have
> been moved to the config file, but the idea is to move them there.
>
> Anthony, please don't apply.
>
> About the problem with bisect, if you start with the lastest version
> config file, it should just work (famous last words).
>
> Later, Juan.

What about overwriting it automatically when it was not modified
by the user? This would only need a backup copy of the original
default configuration. I assume that most users don't change
config-devices.mak, so they would be happy with this solution.
Calling "make defconfig" is only the second best solution for them.

A more sophisticated solution could try to create a patch from
original default configuration and user modified configuration.
Make could try to apply this patch to the new default configuration,
and if there is no conflict, all is fine as well.

Regards, Stefan

  parent reply	other threads:[~2009-11-26 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-22 14:07 [Qemu-devel] [PATCH] Makefile: Add missing rule for config-devices.mak Stefan Weil
2009-11-22 14:20 ` Scott Tsai
2009-11-23 18:55 ` Paul Brook
     [not found] ` <m33a45ia0a.fsf@neno.neno>
2009-11-26 10:25   ` Stefan Weil [this message]
2009-11-26 13:13     ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0E57AC.5090401@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@trasno.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).