From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDbYD-0004mK-Vx for qemu-devel@nongnu.org; Thu, 26 Nov 2009 05:26:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDbY8-0004kU-3V for qemu-devel@nongnu.org; Thu, 26 Nov 2009 05:26:12 -0500 Received: from [199.232.76.173] (port=48164 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDbY7-0004kG-Rb for qemu-devel@nongnu.org; Thu, 26 Nov 2009 05:26:07 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:58849) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDbY7-0001Jp-BJ for qemu-devel@nongnu.org; Thu, 26 Nov 2009 05:26:07 -0500 Message-ID: <4B0E57AC.5090401@mail.berlios.de> Date: Thu, 26 Nov 2009 11:25:48 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1258898842-5222-1-git-send-email-weil@mail.berlios.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Makefile: Add missing rule for config-devices.mak List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Paul Brook , QEMU Developers Juan Quintela schrieb: > Stefan Weil wrote: >> All files config-devices.mak are copies from files in >> directory default-configs. >> >> Creating these copies during configuration ignores these >> dependencies and may result in unresolved externals >> from incremental builds when files in default-configs >> are modified. >> >> By adding a dependency rule to Makefile and executing >> the copy commands there it is possible to run incremental >> builds even with modified default-configs. > > But then, if you have modified the file, you lost your changes. > That file is not overwrote on purpose. Think of it as the .config when > you compile your kernel. If you don't have one, it gets a default one. > But if you have one, it will not overwrote it. Not all devices have > been moved to the config file, but the idea is to move them there. > > Anthony, please don't apply. > > About the problem with bisect, if you start with the lastest version > config file, it should just work (famous last words). > > Later, Juan. What about overwriting it automatically when it was not modified by the user? This would only need a backup copy of the original default configuration. I assume that most users don't change config-devices.mak, so they would be happy with this solution. Calling "make defconfig" is only the second best solution for them. A more sophisticated solution could try to create a patch from original default configuration and user modified configuration. Make could try to apply this patch to the new default configuration, and if there is no conflict, all is fine as well. Regards, Stefan