From: Stefan Weil <weil@mail.berlios.de>
To: David Benjamin <davidben@MIT.EDU>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname()
Date: Fri, 27 Nov 2009 10:31:24 +0100 [thread overview]
Message-ID: <4B0F9C6C.2050707@mail.berlios.de> (raw)
In-Reply-To: <1259202010-20599-1-git-send-email-davidben@mit.edu>
David Benjamin schrieb:
> This should avoid truncating the register name when debugging.
>
> Signed-off-by: David Benjamin <davidben@mit.edu>
> ---
> hw/eepro100.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 8734907..3676dc0 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -648,7 +648,7 @@ static const char * const reg[PCI_IO_SIZE / 4] = {
>
> static char *regname(uint32_t addr)
> {
> - static char buf[16];
> + static char buf[32];
> if (addr < PCI_IO_SIZE) {
> const char *r = reg[addr / 4];
> if (r != 0) {
This was already fixed in the latest version of eepro100.c
(git://repo.or.cz/qemu/ar7.git).
In "official" QEMU on savannah, it is still missing
(as several other patches, too).
It takes more than a week to get a patch integrated...
Regards,
Stefan
prev parent reply other threads:[~2009-11-27 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 2:20 [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer for regname() David Benjamin
2009-11-27 9:31 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0F9C6C.2050707@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=davidben@MIT.EDU \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).