Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state

[Avi Kivity <avi@redhat.com>]

On 11/26/2009 07:24 PM, Glauber Costa wrote:
> This fix a bug with -smp in kvm. Since we have updated apic_base,
> we also have to tell kernel about it. So instead of just updating
> mp_state, update every regs.
>
> Signed-off-by: Glauber Costa<glommer@redhat.com>
> ---
>   hw/apic-kvm.c |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c
> index e5a0bfc..dc61386 100644
> --- a/hw/apic-kvm.c
> +++ b/hw/apic-kvm.c
> @@ -126,7 +126,10 @@ static void kvm_apic_reset(void *opaque)
>       s->cpu_env->mp_state
>               = bsp ? KVM_MP_STATE_RUNNABLE : KVM_MP_STATE_UNINITIALIZED;
>
> -    kvm_put_mp_state(s->cpu_env);
> +    /* We have to tell the kernel about mp_state, but also save sregs, since
> +     * apic base was just updated
> +     */
> +    kvm_arch_put_registers(s->cpu_env);
>
>    

Better to use cpu_synchronize_state() instead.

-- 
error compiling committee.c: too many arguments to function