From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NF50Q-0003QA-Sb
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:05:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NF50M-0003NT-O5
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:05:26 -0500
Received: from [199.232.76.173] (port=50681 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NF50M-0003NL-Jh
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:05:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44246)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NF50M-0004nE-6f
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:05:22 -0500
Message-ID: <4B13B4FE.4040107@redhat.com>
Date: Mon, 30 Nov 2009 14:05:18 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead
	of just mp_state
References: <1259256300-23937-1-git-send-email-glommer@redhat.com>	<1259256300-23937-2-git-send-email-glommer@redhat.com>	<1259256300-23937-3-git-send-email-glommer@redhat.com>	<1259256300-23937-4-git-send-email-glommer@redhat.com>	<1259256300-23937-5-git-send-email-glommer@redhat.com>	<1259256300-23937-6-git-send-email-glommer@redhat.com>	<4B129425.8090006@redhat.com>
	<5d6222a80911300345w3df34c9bvad12344df484d935@mail.gmail.com>
In-Reply-To: <5d6222a80911300345w3df34c9bvad12344df484d935@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On 11/30/2009 01:45 PM, Glauber Costa wrote:
>>
>> Better to use cpu_synchronize_state() instead.
>>
>>      
> I might be misreading it, but :
>
> void kvm_cpu_synchronize_state(CPUState *env)
> {
>      if (!env->kvm_state->regs_modified) {
>          kvm_arch_get_registers(env);
>          env->kvm_state->regs_modified = 1;
>      }
> }
>
> Only does get. And we need put.
>    

It will autoput during the next guest entry.

-- 
error compiling committee.c: too many arguments to function