From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF51T-00040W-NC for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:06:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF51P-0003yP-TE for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:06:31 -0500 Received: from [199.232.76.173] (port=52706 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF51P-0003yD-IG for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:06:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51704) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF51P-0004zi-BD for qemu-devel@nongnu.org; Mon, 30 Nov 2009 07:06:27 -0500 Message-ID: <4B13B53F.2060207@redhat.com> Date: Mon, 30 Nov 2009 14:06:23 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/7] qemu_flush_work for remote vcpu execution References: <1259256300-23937-1-git-send-email-glommer@redhat.com> <1259256300-23937-2-git-send-email-glommer@redhat.com> <1259256300-23937-3-git-send-email-glommer@redhat.com> <1259256300-23937-4-git-send-email-glommer@redhat.com> <1259256300-23937-5-git-send-email-glommer@redhat.com> <4B1293F2.4020702@redhat.com> <5d6222a80911300344y7ad2fdf0odff84d3767abcdc3@mail.gmail.com> In-Reply-To: <5d6222a80911300344y7ad2fdf0odff84d3767abcdc3@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: Glauber Costa , aliguori@us.ibm.com, qemu-devel@nongnu.org On 11/30/2009 01:44 PM, Glauber Costa wrote: >> I really dislike this. In general vcpu ioctls are used as components of >> some work to be done, for example RMW of some state. In this case it is >> meaningless to execute the ioctls remotely, you need to execute the entire >> RMW remotely instead. >> >> > Why? The "M" part of RMW is executed in shared memory. > Only the R and W parts have any restrictions on where to be executed. > > If the guest continues to run during the RMW, you will get inconsistent results. This may be prevented by qemu_mutex, but I'd rather not rely on it. Also, I'd like remote operations to be visible. -- error compiling committee.c: too many arguments to function