From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF9D3-0003ow-2E for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:34:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF9Cw-0003n8-2K for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:34:41 -0500 Received: from [199.232.76.173] (port=44700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9Cv-0003mu-J0 for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:34:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5517) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NF9Cv-00060F-4X for qemu-devel@nongnu.org; Mon, 30 Nov 2009 11:34:37 -0500 Message-ID: <4B13F419.7020306@redhat.com> Date: Mon, 30 Nov 2009 18:34:33 +0200 From: Avi Kivity MIME-Version: 1.0 References: <5d6222a80911300800o6aa548f0r88edd8e1e66e758e@mail.gmail.com> In-Reply-To: <5d6222a80911300800o6aa548f0r88edd8e1e66e758e@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: Use per-cpu reset handlers. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: qemu-devel@nongnu.org On 11/30/2009 06:00 PM, Glauber Costa wrote: > The proposal in this patch is to add a system_reset caller that only > resets state related to the cpu. This will guarantee that does functions > are called from the cpu-threads, not the I/O thread. > > In principle, it might seem close to the remote execution mechanism, but: > * It does not involve any extra signalling, so it should be faster. > * The cpu is guaranteed to be stopped, so it is much less racy. > * What runs where becomes more explicit. > * This is much, much less racy > > The previous implementation was giving me races on reset. This one makes > it work flawlesly w.r.t reset. > Looks pretty good. -- error compiling committee.c: too many arguments to function