From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFB5C-0004RE-RX
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 13:34:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFB57-0004Om-Ov
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 13:34:46 -0500
Received: from [199.232.76.173] (port=35117 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFB57-0004OY-9E
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 13:34:41 -0500
Received: from mail-qy0-f194.google.com ([209.85.221.194]:37902)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NFB56-0003ZP-N6
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 13:34:41 -0500
Received: by qyk32 with SMTP id 32so1678974qyk.4
	for <qemu-devel@nongnu.org>; Mon, 30 Nov 2009 10:34:36 -0800 (PST)
Message-ID: <4B141038.2030909@codemonkey.ws>
Date: Mon, 30 Nov 2009 12:34:32 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 00/23] block migration: Fixes, cleanups and
	speedups
References: <20091130172119.22889.28114.stgit@mchn012c.ww002.siemens.net>
In-Reply-To: <20091130172119.22889.28114.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, Liran Schour <lirans@il.ibm.com>, Pierre Riteau <pierre.riteau@irisa.fr>

Jan Kiszka wrote:
> This series is a larger rework of the block migration support qemu
> recently gained. Besides lots of code refactorings the major changes
> are:
>  - Faster restore due to larger block sizes (even if the target disk is
>    unallocated)
>  - Off-by-one fixes in the block dirty tracking code
>  - Allow for multiple migrations (after cancellation or if migrating
>    into a backup image)
>  - Proper error handling
>  - Progress reporting fixes: report to monitor instead of stdout, report
>    sum of multiple disks
>  - Report disk migration progress via 'info migrate'
>  - Progress report during restore
>
> One patch is directly taken from Pierre Riteau queue [1] who happend to
> work on the some topic the last days, two more are derived from his
> commits.
>
> These patches make block migration usable for us. Still, there are two
> more major improvements on my wish/todo list:
>  - Respect specified maximum migration downtime (will require tracking
>    of the number of dirty blocks + some coordination with ram migration)
>  - Do not transfere unallocated disk space (also for raw images, ie. add
>    bdrv_is_allocated support for the latter)
>
> In an off-list chat, Liran additionally brought up the topic that RAM
> migration should not start too early so that we avoid re-transmitting
> dirty pages over and over again while the disk image is slowly beamed
> over.
>
> I hope we can join our efforts to resolve the open topics quickly, the
> critical ones ideally before the merge window closes.
>   

That really needs to happen no later than the end of this week.

So Pierre/Liran, what do you think about Jan's series?

Regards,

Anthony Liguori