qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Pierre Riteau <Pierre.Riteau@irisa.fr>,
	qemu-devel <qemu-devel@nongnu.org>,
	Liran Schour <LIRANS@il.ibm.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH] vmstate: Fix info field of VMSTATE_MACADDR
Date: Tue, 01 Dec 2009 20:00:07 +0100	[thread overview]
Message-ID: <4B1567B7.60107@siemens.com> (raw)

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

This may partly or fully explain the e1000 issue Pierre reported first.
However, there are more bugs in the current migration code, e.g. in
qemu_fseek when used with streams, it still doesn't work properly here.
Need a break...

 hw/hw.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/hw.h b/hw/hw.h
index 86ee716..dc119f0 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -546,7 +546,7 @@ extern const VMStateDescription vmstate_i2c_slave;
 #define VMSTATE_MACADDR(_field, _state) {                            \
     .name       = (stringify(_field)),                               \
     .size       = sizeof(MACAddr),                                   \
-    .info       = &vmstate_info_uint8,                               \
+    .info       = &vmstate_info_buffer,                              \
     .flags      = VMS_BUFFER,                                        \
     .offset     = vmstate_offset_macaddr(_state, _field),            \
 }

             reply	other threads:[~2009-12-01 19:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 19:00 Jan Kiszka [this message]
2009-12-01 19:24 ` [Qemu-devel] Re: [PATCH] vmstate: Fix info field of VMSTATE_MACADDR Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1567B7.60107@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=LIRANS@il.ibm.com \
    --cc=Pierre.Riteau@irisa.fr \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).