* [Qemu-devel] [PATCH] vmstate: Fix info field of VMSTATE_MACADDR
@ 2009-12-01 19:00 Jan Kiszka
2009-12-01 19:24 ` [Qemu-devel] " Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2009-12-01 19:00 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Pierre Riteau, qemu-devel, Liran Schour, Juan Quintela
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
This may partly or fully explain the e1000 issue Pierre reported first.
However, there are more bugs in the current migration code, e.g. in
qemu_fseek when used with streams, it still doesn't work properly here.
Need a break...
hw/hw.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index 86ee716..dc119f0 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -546,7 +546,7 @@ extern const VMStateDescription vmstate_i2c_slave;
#define VMSTATE_MACADDR(_field, _state) { \
.name = (stringify(_field)), \
.size = sizeof(MACAddr), \
- .info = &vmstate_info_uint8, \
+ .info = &vmstate_info_buffer, \
.flags = VMS_BUFFER, \
.offset = vmstate_offset_macaddr(_state, _field), \
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] vmstate: Fix info field of VMSTATE_MACADDR
2009-12-01 19:00 [Qemu-devel] [PATCH] vmstate: Fix info field of VMSTATE_MACADDR Jan Kiszka
@ 2009-12-01 19:24 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2009-12-01 19:24 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Anthony Liguori, qemu-devel, Liran Schour, Pierre Riteau
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> This may partly or fully explain the e1000 issue Pierre reported first.
> However, there are more bugs in the current migration code, e.g. in
> qemu_fseek when used with streams, it still doesn't work properly here.
> Need a break...
You arrived at the same conclussion than me :(
> hw/hw.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/hw.h b/hw/hw.h
> index 86ee716..dc119f0 100644
> --- a/hw/hw.h
> +++ b/hw/hw.h
> @@ -546,7 +546,7 @@ extern const VMStateDescription vmstate_i2c_slave;
> #define VMSTATE_MACADDR(_field, _state) { \
> .name = (stringify(_field)), \
> .size = sizeof(MACAddr), \
> - .info = &vmstate_info_uint8, \
> + .info = &vmstate_info_buffer, \
> .flags = VMS_BUFFER, \
> .offset = vmstate_offset_macaddr(_state, _field), \
> }
Good catch.
Later, Juan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-01 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 19:00 [Qemu-devel] [PATCH] vmstate: Fix info field of VMSTATE_MACADDR Jan Kiszka
2009-12-01 19:24 ` [Qemu-devel] " Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).