From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFmYM-0006XW-8A for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:35:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFmYH-0006Wq-5q for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:35:21 -0500 Received: from [199.232.76.173] (port=42471 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFmYH-0006Wn-1S for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:35:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1025) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFmYG-0004hr-MK for qemu-devel@nongnu.org; Wed, 02 Dec 2009 05:35:17 -0500 Message-ID: <4B1642A0.5030701@redhat.com> Date: Wed, 02 Dec 2009 11:34:08 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] Don't leak file descriptors References: <1258386420-23294-1-git-send-email-kwolf@redhat.com> <4B153C60.2060605@suse.de> In-Reply-To: <4B153C60.2060605@suse.de> Content-Type: multipart/mixed; boundary="------------090209070500080906040403" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------090209070500080906040403 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id nB2AZEJF005029 Am 01.12.2009 16:55, schrieb Alexander Graf: > Kevin Wolf wrote: >> We're leaking file descriptors to child processes. Set FD_CLOEXEC on f= ile >> descriptors that don't need to be passed to children to stop this misb= ehaviour. >> >> Signed-off-by: Kevin Wolf > > On Anthony's staging tree: >=20 > cc1: warnings being treated as errors > osdep.c: In function =E2=80=98qemu_accept=E2=80=99: > osdep.c:304: error: implicit declaration of function =E2=80=98accept4=E2= =80=99 Does this one on top work for you? Kevin --------------090209070500080906040403 Content-Type: text/plain; name="fix_accept4.patch" Content-Disposition: attachment; filename="fix_accept4.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZSBiL2NvbmZpZ3VyZQppbmRleCBkY2E1YTQzLi4wYTFl MzQ3IDEwMDc1NQotLS0gYS9jb25maWd1cmUKKysrIGIvY29uZmlndXJlCkBAIC0xNTUwLDYg KzE1NTAsMjMgQEAgaWYgY29tcGlsZV9wcm9nICIiICIiIDsgdGhlbgogICBwaXBlMj15ZXMK IGZpCiAKKyMgY2hlY2sgaWYgYWNjZXB0NCBpcyB0aGVyZQorYWNjZXB0ND1ubworY2F0ID4g JFRNUEMgPDwgRU9GCisjZGVmaW5lIF9HTlVfU09VUkNFCisjaW5jbHVkZSA8c3lzL3NvY2tl dC5oPgorI2luY2x1ZGUgPHN0ZGRlZi5oPgorCitpbnQgbWFpbih2b2lkKQoreworICAgIGFj Y2VwdDQoMCwgTlVMTCwgTlVMTCwgU09DS19DTE9FWEVDKTsKKyAgICByZXR1cm4gMDsKK30K K0VPRgoraWYgY29tcGlsZV9wcm9nICIiICIiIDsgdGhlbgorICBhY2NlcHQ0PXllcworZmkK KwogIyBjaGVjayBpZiB0ZWUvc3BsaWNlIGlzIHRoZXJlLiB2bXNwbGljZSB3YXMgYWRkZWQg c2FtZSB0aW1lLgogc3BsaWNlPW5vCiBjYXQgPiAkVE1QQyA8PCBFT0YKQEAgLTIwMTMsNiAr MjAzMCw5IEBAIGZpCiBpZiB0ZXN0ICIkcGlwZTIiID0gInllcyIgOyB0aGVuCiAgIGVjaG8g IkNPTkZJR19QSVBFMj15IiA+PiAkY29uZmlnX2hvc3RfbWFrCiBmaQoraWYgdGVzdCAiJGFj Y2VwdDQiID0gInllcyIgOyB0aGVuCisgIGVjaG8gIkNPTkZJR19BQ0NFUFQ0PXkiID4+ICRj b25maWdfaG9zdF9tYWsKK2ZpCiBpZiB0ZXN0ICIkc3BsaWNlIiA9ICJ5ZXMiIDsgdGhlbgog ICBlY2hvICJDT05GSUdfU1BMSUNFPXkiID4+ICRjb25maWdfaG9zdF9tYWsKIGZpCmRpZmYg LS1naXQgYS9vc2RlcC5jIGIvb3NkZXAuYwppbmRleCAwMzkwNjVlLi43NTA5YzViIDEwMDY0 NAotLS0gYS9vc2RlcC5jCisrKyBiL29zZGVwLmMKQEAgLTI2MCw3ICsyNjAsNyBAQCBpbnQg cWVtdV9waXBlKGludCBwaXBlZmRbMl0pCiB7CiAgICAgaW50IHJldDsKIAotI2lmZGVmIE9f Q0xPRVhFQworI2lmZGVmIENPTkZJR19QSVBFMgogICAgIHJldCA9IHBpcGUyKHBpcGVmZCwg T19DTE9FWEVDKTsKICNlbHNlCiAgICAgcmV0ID0gcGlwZShwaXBlZmQpOwpAQCAtMzAwLDcg KzMwMCw3IEBAIGludCBxZW11X2FjY2VwdChpbnQgcywgc3RydWN0IHNvY2thZGRyICphZGRy LCBzb2NrbGVuX3QgKmFkZHJsZW4pCiB7CiAgICAgaW50IHJldDsKIAotI2lmZGVmIFNPQ0tf Q0xPRVhFQworI2lmZGVmIENPTkZJR19BQ0NFUFQ0CiAgICAgcmV0ID0gYWNjZXB0NChzLCBh ZGRyLCBhZGRybGVuLCBTT0NLX0NMT0VYRUMpOwogI2Vsc2UKICAgICByZXQgPSBhY2NlcHQo cywgYWRkciwgYWRkcmxlbik7Cg== --------------090209070500080906040403--