From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NFnAZ-0000Tg-TC
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:14:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NFnAV-0000Rd-N3
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:14:51 -0500
Received: from [199.232.76.173] (port=39467 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NFnAV-0000RY-Fq
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:14:47 -0500
Received: from goliath.siemens.de ([192.35.17.28]:17026)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1NFnAV-0000Kf-1e
	for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:14:47 -0500
Message-ID: <4B164C21.3040406@siemens.com>
Date: Wed, 02 Dec 2009 12:14:41 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4B15A8FA.5080804@web.de> <m3eindn11u.fsf@neno.neno>
In-Reply-To: <m3eindn11u.fsf@neno.neno>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] vmstate: Avoid seeking
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Liran Schour <LIRANS@il.ibm.com>, Pierre Riteau <Pierre.Riteau@irisa.fr>

Juan Quintela wrote:
> Jan Kiszka <jan.kiszka@web.de> wrote:
>> Seeking on vmstate save/load does not work if the underlying file is a
>> stream. We could try to make all QEMUFile* forward-seek-aware, but first
>> attempts in this direction indicated that it's saner to convert the few
>> qemu_fseek-on-vmstates users to plain reads/writes.
>>
>> This fixes various subtle vmstate corruptions where unused fields were
>> involved.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Something changed lately.  This used to work, and I also waste^spend
> yesterday trying to understand why it was failing to me.

I'm quite sure it never really worked. Maybe the bug was just papered over.

> 
> I am splitting the patch in virtio-net and savevm parts.  (In my tree
> virtio-net don't use fseek anymore).

OK, then I will drop this patch from my queue. BTW, where is your tree
hosted?

> 
> Thanks for finding the bug.
> 
> Later, Juan.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux