From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFnNL-0002QO-Bl for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:28:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFnNG-0002OR-RL for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:28:02 -0500 Received: from [199.232.76.173] (port=42801 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFnNG-0002OM-Fp for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:27:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65088) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFnNE-0001SR-NF for qemu-devel@nongnu.org; Wed, 02 Dec 2009 06:27:58 -0500 Message-ID: <4B164EF7.4070201@redhat.com> Date: Wed, 02 Dec 2009 12:26:47 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1259753082-24840-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1259753082-24840-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Am 02.12.2009 12:24, schrieb Kevin Wolf: > We're leaking file descriptors to child processes. Set FD_CLOEXEC on file > descriptors that don't need to be passed to children to stop this misbehaviour. > > Signed-off-by: Kevin Wolf > --- > > v2: > - The existence of SOCK_CLOEXEC doesn't mean that accept4 exists. Added a check > for it in configure. v3 even. Anthony, I hope this doesn't confuse your scripts? Kevin