From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFohG-0002RG-0l for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:52:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFohB-0002PU-50 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:52:41 -0500 Received: from [199.232.76.173] (port=45736 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFohA-0002PL-VJ for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:52:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18489) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFohA-0008Qq-IH for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:52:36 -0500 Message-ID: <4B166311.7040300@redhat.com> Date: Wed, 02 Dec 2009 14:52:33 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20091130190226.GB457@redhat.com> In-Reply-To: <20091130190226.GB457@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCHv5-repost 1/2] qemu: make cirrus init value pci spec compliant List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel , Juan Quintela On 11/30/2009 09:02 PM, Michael S. Tsirkin wrote: > PCI memory should be disabled at reset, otherwise > we might claim transactions at address 0. > I/O should also be disabled, although for cirrus > it is harmless to enable it as we do not > have I/O bar. > > Note: bios fix needed for this patch to work > was already applied: > previously bios incorrently assumed that it does not > need to enable i/o unless device has i/o bar. > Is this for qemu-kvm.git or qemu.git? -- error compiling committee.c: too many arguments to function