From: Kevin Wolf <kwolf@redhat.com>
To: Scott Tsai <scottt.tw@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors
Date: Wed, 02 Dec 2009 13:58:14 +0100 [thread overview]
Message-ID: <4B166466.2080805@redhat.com> (raw)
In-Reply-To: <ef2f888d0912020403w121542bbkf795a8376064cb12@mail.gmail.com>
Am 02.12.2009 13:03, schrieb Scott Tsai:
> On Wed, Dec 2, 2009 at 7:26 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> v3 even. Anthony, I hope this doesn't confuse your scripts?
>
> Kevin, I see use of fopen, fdopen, popen, eventfd in qemu without the
> equivalent of CLOEXEC set.
> Do you want to handle those in this patch series as well?
In the first instance, I'd like to see this one go in as it fixes the
common cases. Otherwise we could probably reiterate with new versions
for quite a while until really all files are covered.
It's well possible that I still missed some calls. I haven't seen any
file descriptors leaked any more in my test runs, but probably you just
need to use the right options. Feel free to follow up with an additional
patch.
Kevin
next prev parent reply other threads:[~2009-12-02 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 11:24 [Qemu-devel] [PATCH v2] Don't leak file descriptors Kevin Wolf
2009-12-02 11:26 ` [Qemu-devel] " Kevin Wolf
2009-12-02 12:03 ` Scott Tsai
2009-12-02 12:58 ` Kevin Wolf [this message]
2009-12-02 14:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B166466.2080805@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=scottt.tw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).