From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFono-0005k8-88 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:59:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFonj-0005jH-NL for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:59:27 -0500 Received: from [199.232.76.173] (port=59207 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFonj-0005jE-J7 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:59:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31140) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFonj-0000PN-6C for qemu-devel@nongnu.org; Wed, 02 Dec 2009 07:59:23 -0500 Message-ID: <4B166466.2080805@redhat.com> Date: Wed, 02 Dec 2009 13:58:14 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors References: <1259753082-24840-1-git-send-email-kwolf@redhat.com> <4B164EF7.4070201@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Tsai Cc: qemu-devel@nongnu.org Am 02.12.2009 13:03, schrieb Scott Tsai: > On Wed, Dec 2, 2009 at 7:26 PM, Kevin Wolf wrote: >> v3 even. Anthony, I hope this doesn't confuse your scripts? > > Kevin, I see use of fopen, fdopen, popen, eventfd in qemu without the > equivalent of CLOEXEC set. > Do you want to handle those in this patch series as well? In the first instance, I'd like to see this one go in as it fixes the common cases. Otherwise we could probably reiterate with new versions for quite a while until really all files are covered. It's well possible that I still missed some calls. I haven't seen any file descriptors leaked any more in my test runs, but probably you just need to use the right options. Feel free to follow up with an additional patch. Kevin