From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFpoi-0001UU-Aj for qemu-devel@nongnu.org; Wed, 02 Dec 2009 09:04:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFpod-0001Rt-Ml for qemu-devel@nongnu.org; Wed, 02 Dec 2009 09:04:27 -0500 Received: from [199.232.76.173] (port=38908 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFpod-0001Re-86 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 09:04:23 -0500 Received: from mail-gx0-f223.google.com ([209.85.217.223]:47505) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFpoc-0005dv-QL for qemu-devel@nongnu.org; Wed, 02 Dec 2009 09:04:22 -0500 Received: by gxk23 with SMTP id 23so176497gxk.2 for ; Wed, 02 Dec 2009 06:04:19 -0800 (PST) Message-ID: <4B1673E0.1030301@codemonkey.ws> Date: Wed, 02 Dec 2009 08:04:16 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1259753082-24840-1-git-send-email-kwolf@redhat.com> <4B164EF7.4070201@redhat.com> In-Reply-To: <4B164EF7.4070201@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] Don't leak file descriptors List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf wrote: > Am 02.12.2009 12:24, schrieb Kevin Wolf: > >> We're leaking file descriptors to child processes. Set FD_CLOEXEC on file >> descriptors that don't need to be passed to children to stop this misbehaviour. >> >> Signed-off-by: Kevin Wolf >> --- >> >> v2: >> - The existence of SOCK_CLOEXEC doesn't mean that accept4 exists. Added a check >> for it in configure. >> > > v3 even. Anthony, I hope this doesn't confuse your scripts? > No worries, I'll straighten it out. > Kevin > Regards, Anthony Liguori