From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGAfS-00050f-QU
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:20:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGAfN-0004xB-Q6
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:20:17 -0500
Received: from [199.232.76.173] (port=57405 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGAfN-0004wx-Bk
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:20:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51868)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NGAfM-00082Z-S4
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:20:13 -0500
Message-ID: <4B17ACF9.8030003@redhat.com>
Date: Thu, 03 Dec 2009 14:20:09 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1259761702-4041-1-git-send-email-glommer@redhat.com>
	<1259761702-4041-2-git-send-email-glommer@redhat.com>
	<1259761702-4041-3-git-send-email-glommer@redhat.com>
	<1259761702-4041-4-git-send-email-glommer@redhat.com>
	<1259761702-4041-5-git-send-email-glommer@redhat.com>
In-Reply-To: <1259761702-4041-5-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu
	execution
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 12/02/2009 03:48 PM, Glauber Costa wrote:
> This function is similar to qemu-kvm's on_vcpu mechanism.

Is similar?  You're replacing on_vcpu().

> Totally synchronous,
> and guarantees that a given function will be executed at the specified vcpu.
>
> This patch also convert usage within the breakpoints system
>
> +void qemu_queue_work(CPUState *env, void (*func)(void *data), void *data);
>    

The name suggests that it is asynchronous.

Why is this patch necessary?

-- 
error compiling committee.c: too many arguments to function