From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGAuS-0001Rh-DJ
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:35:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGAuN-0001Nh-IZ
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:35:47 -0500
Received: from [199.232.76.173] (port=36537 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGAuN-0001NW-BF
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:35:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23564)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NGAuM-0000tX-UG
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:35:43 -0500
Message-ID: <4B17B09B.8030107@redhat.com>
Date: Thu, 03 Dec 2009 14:35:39 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu
	execution
References: <1259761702-4041-1-git-send-email-glommer@redhat.com>	
	<1259761702-4041-2-git-send-email-glommer@redhat.com>	
	<1259761702-4041-3-git-send-email-glommer@redhat.com>	
	<1259761702-4041-4-git-send-email-glommer@redhat.com>	
	<1259761702-4041-5-git-send-email-glommer@redhat.com>	
	<4B17ACF9.8030003@redhat.com>
	<5d6222a80912030433w34220aebv3681724692b9c2a@mail.gmail.com>
In-Reply-To: <5d6222a80912030433w34220aebv3681724692b9c2a@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On 12/03/2009 02:33 PM, Glauber Costa wrote:
> On Thu, Dec 3, 2009 at 10:20 AM, Avi Kivity<avi@redhat.com>  wrote:
>    
>> On 12/02/2009 03:48 PM, Glauber Costa wrote:
>>      
>>> This function is similar to qemu-kvm's on_vcpu mechanism.
>>>        
>> Is similar?  You're replacing on_vcpu().
>>      
> Yeah, it began similar, now it is pretty much the same thing, but
> using qemu-specific
> data structures
>    

Keep the name then.  The new name is misleading.

>>> Totally synchronous,
>>> and guarantees that a given function will be executed at the specified
>>> vcpu.
>>>
>>> This patch also convert usage within the breakpoints system
>>>
>>> +void qemu_queue_work(CPUState *env, void (*func)(void *data), void
>>> *data);
>>>
>>>        
>> The name suggests that it is asynchronous.
>>
>> Why is this patch necessary?
>>      
> to keep gdbstub working.
>    

"Because it fixes things".

Please elaborate.

-- 
error compiling committee.c: too many arguments to function