From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGAyj-00058w-VK
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:40:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGAyf-00054c-B4
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:40:13 -0500
Received: from [199.232.76.173] (port=46530 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGAye-00054K-U5
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:40:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20231)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1NGAye-0001NQ-CN
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 07:40:08 -0500
Message-ID: <4B17B1A4.8070209@redhat.com>
Date: Thu, 03 Dec 2009 14:40:04 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu
	execution
References: <1259761702-4041-1-git-send-email-glommer@redhat.com>	
	<1259761702-4041-2-git-send-email-glommer@redhat.com>	
	<1259761702-4041-3-git-send-email-glommer@redhat.com>	
	<1259761702-4041-4-git-send-email-glommer@redhat.com>	
	<1259761702-4041-5-git-send-email-glommer@redhat.com>	
	<4B17ACF9.8030003@redhat.com>	
	<5d6222a80912030433w34220aebv3681724692b9c2a@mail.gmail.com>	
	<4B17B09B.8030107@redhat.com>
	<5d6222a80912030437o3be79b67wf88d4c6b275aa526@mail.gmail.com>
In-Reply-To: <5d6222a80912030437o3be79b67wf88d4c6b275aa526@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On 12/03/2009 02:37 PM, Glauber Costa wrote:
>> "Because it fixes things".
>>
>> Please elaborate.
>>
>>      
> gdbstub is called from the i/o thread , and call vcpu ioctls. So it
> has to use the on_vcpu
> mechanism to guarantee its execution in the right thread.
>
> What I meant is that currently, gdbstub is the only user of it, at
> least in qemu.git
>    

In this case, the patch is unnecessary for smp.  Please submit it 
separately from this patchset, with a proper changelog.


-- 
error compiling committee.c: too many arguments to function