From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution
Date: Thu, 03 Dec 2009 15:29:25 +0100 [thread overview]
Message-ID: <4B17CB45.90607@redhat.com> (raw)
In-Reply-To: <1259761702-4041-5-git-send-email-glommer@redhat.com>
On 12/02/2009 02:48 PM, Glauber Costa wrote:
> + if (env == qemu_get_current_env()) {
Will always be false for TCG + iothread. What's wrong with
qemu_cpu_self(env)? It appears to do the same, and it would also make
the whole thread-local storage stuff redundant.
If there are performance problems, you can fix them by using TLS for the
KVM case and keeping the existing implementation for TCG; at which point
you can just use __thread because KVM can assume Linux and hence a
working __thread.
Paolo
next prev parent reply other threads:[~2009-12-03 14:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 13:48 [Qemu-devel] [PATCH 00/11] SMP support in qemu.git Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 01/11] Don't mess with halted state Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 02/11] store thread-specific env information Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 03/11] update halted state on mp_state sync Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 04/11] qemu_flush_work for remote vcpu execution Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 05/11] tell kernel about all registers instead of just mp_state Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 06/11] flush state in migration post_load Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 07/11] Don't call kvm cpu reset on initialization Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 08/11] use cpu_kick instead of direct signalling Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 09/11] Use per-cpu reset handlers Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 10/11] Use __thread where available Glauber Costa
2009-12-02 13:48 ` [Qemu-devel] [PATCH 11/11] remove smp restriction from kvm Glauber Costa
2009-12-03 12:23 ` [Qemu-devel] " Avi Kivity
2009-12-03 12:36 ` Glauber Costa
2009-12-03 12:37 ` Avi Kivity
2009-12-03 12:39 ` Glauber Costa
2009-12-03 12:40 ` Avi Kivity
2009-12-03 12:20 ` [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu execution Avi Kivity
2009-12-03 12:33 ` Glauber Costa
2009-12-03 12:35 ` Avi Kivity
2009-12-03 12:37 ` Glauber Costa
2009-12-03 12:40 ` Avi Kivity
2009-12-03 14:29 ` Paolo Bonzini [this message]
2009-12-03 15:02 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B17CB45.90607@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).