From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGCgc-0007ks-6R
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:29:38 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGCgV-0007j5-A4
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:29:36 -0500
Received: from [199.232.76.173] (port=34810 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGCgU-0007ih-0U
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:29:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40428)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1NGCgT-0003G4-Rv
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 09:29:30 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB3ETR5b011097
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 3 Dec 2009 09:29:27 -0500
Received: from yakj.usersys.redhat.com (dhcp-lab-164.englab.brq.redhat.com
	[10.34.33.164])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id nB3ETQKX002747
	for <qemu-devel@nongnu.org>; Thu, 3 Dec 2009 09:29:27 -0500
Message-ID: <4B17CB45.90607@redhat.com>
Date: Thu, 03 Dec 2009 15:29:25 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1259761702-4041-1-git-send-email-glommer@redhat.com>	<1259761702-4041-2-git-send-email-glommer@redhat.com>	<1259761702-4041-3-git-send-email-glommer@redhat.com>	<1259761702-4041-4-git-send-email-glommer@redhat.com>
	<1259761702-4041-5-git-send-email-glommer@redhat.com>
In-Reply-To: <1259761702-4041-5-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 04/11] qemu_flush_work for remote vcpu
	execution
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

On 12/02/2009 02:48 PM, Glauber Costa wrote:
> +    if (env == qemu_get_current_env()) {

Will always be false for TCG + iothread.  What's wrong with 
qemu_cpu_self(env)?  It appears to do the same, and it would also make 
the whole thread-local storage stuff redundant.

If there are performance problems, you can fix them by using TLS for the 
KVM case and keeping the existing implementation for TCG; at which point 
you can just use __thread because KVM can assume Linux and hence a 
working __thread.

Paolo