From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGHmV-0005Us-Nw
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:56:03 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGHmQ-0005NH-0Y
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:56:02 -0500
Received: from [199.232.76.173] (port=53317 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGHmP-0005Mm-Aa
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:55:57 -0500
Received: from mail-iw0-f197.google.com ([209.85.223.197]:44308)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NGHmP-0004pc-4V
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 14:55:57 -0500
Received: by iwn35 with SMTP id 35so1168199iwn.4
	for <qemu-devel@nongnu.org>; Thu, 03 Dec 2009 11:55:56 -0800 (PST)
Message-ID: <4B1817C7.3000804@codemonkey.ws>
Date: Thu, 03 Dec 2009 13:55:51 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/4] Rename DriveInfo.onerror to
	on_write_error
References: <1259324739-6805-1-git-send-email-kwolf@redhat.com>	<1259324739-6805-2-git-send-email-kwolf@redhat.com>
	<20091129104654.GB30150@redhat.com>
In-Reply-To: <20091129104654.GB30150@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

Gleb Natapov wrote:
> On Fri, Nov 27, 2009 at 01:25:36PM +0100, Kevin Wolf wrote:
>   
>> Either rename variables and functions to refer to write errors (which is what
>> they actually do) or introduce a parameter to distinguish reads and writes.
>>
>>     
> I prefer either to use two different functions or hide 0/1 parameter behind
> a macro:
>  #define drive_get_on_write_error(a) drive_get_on_error(a, 0);
>   

Or a static inline.  But honestly, having three globally scoped 
functions shouldn't be a problem.

Regards,

Anthony Liguori