From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGLer-0002o2-Sd
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 19:04:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGLem-0002jA-6e
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 19:04:24 -0500
Received: from [199.232.76.173] (port=48542 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGLem-0002j3-2s
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 19:04:20 -0500
Received: from qw-out-1920.google.com ([74.125.92.145]:46403)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NGLel-00035N-R8
	for qemu-devel@nongnu.org; Thu, 03 Dec 2009 19:04:19 -0500
Received: by qw-out-1920.google.com with SMTP id 14so145689qwa.4
	for <qemu-devel@nongnu.org>; Thu, 03 Dec 2009 16:04:19 -0800 (PST)
Message-ID: <4B185200.4050301@codemonkey.ws>
Date: Thu, 03 Dec 2009 18:04:16 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Staging update (0.12 pending freeze)
References: <4B1699D3.8010908@codemonkey.ws>	<4B17B057.1070004@redhat.com>	<4B1847EE.7060706@codemonkey.ws>
	<20091203215350.7159df5d@doriath>
In-Reply-To: <20091203215350.7159df5d@doriath>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Luiz Capitulino wrote:
> On Thu, 03 Dec 2009 17:21:18 -0600
> Anthony Liguori <anthony@codemonkey.ws> wrote:
>
>   
>>> Finally the 'default devices' patch series ('must have' IMHO):
>>>
>>>   http://patchwork.ozlabs.org/patch/39180/ (patch 1/10)
>>>
>>> Without that one using -device and -readconfig becomes much harder.
>>>       
>> This series doesn't get along with the QMP monitor support that's been 
>> added recently.  That's because there is now a set of monitor flags and 
>> -monitor takes more than a character device as an argument.
>>     
>
>  For QMP there is only one flag, which is 'control', like:
>
> -monitor control,<device>
>
>  Multiple Monitors work just fine, like:
>
> -monitor stdio -monitor control,tcp:localhost:444,server
>
>  I've even tested multiple QMP monitors iirc. :)
>
>   
>> Honestly, I don't really like multiplexing the -monitor option to 
>> support qmp.  I think I would have a proper -qmp option at the top 
>> level.  That would integrate much more nicely too with this default 
>> devices series.  Luiz, what do you think?
>>     
>
>  Multiplexing the monitor is really useful for testing and it doesn't
> seem reasonable to me to drop this feature just because we can't
> add a single flag to an existing command-line option.
>   

Problem is, control is not a property of the character device. To 
express this in a consistent way with everything else, you would have to 
make this QemuOpts-like so it would look like

-monitor control,device=tcp:localhost:444,server

But so far, the monitor, serial, parallel, etc. devices don't take QemuOpts.

OTH, having:

-qmp tcp:localhost:444,server

Matches the other option types in a consistent manner. If you want to 
support muxing, just add a qmp: prefix to the mux device.

Regards,

Anthony Liguori