From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NGgfz-0007HS-Ps
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 17:30:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NGgfu-0007C1-Ji
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 17:30:58 -0500
Received: from [199.232.76.173] (port=41140 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NGgfu-0007Bc-Av
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 17:30:54 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:63994)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NGgfu-0003Ig-7v
	for qemu-devel@nongnu.org; Fri, 04 Dec 2009 17:30:54 -0500
Received: by yxe26 with SMTP id 26so2654632yxe.4
	for <qemu-devel@nongnu.org>; Fri, 04 Dec 2009 14:30:53 -0800 (PST)
Message-ID: <4B198D96.6090407@codemonkey.ws>
Date: Fri, 04 Dec 2009 16:30:46 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Get coding style closer to the real world
References: <1259618155-4217-1-git-send-email-agraf@suse.de>
	<200912041747.06776.paul@codesourcery.com>
In-Reply-To: <200912041747.06776.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Paul Brook wrote:
> On Monday 30 November 2009, Alexander Graf wrote:
>   
>> Currently we have this stupid role of disallowing:
>>
>>   if (r)
>>       break;
>>     
>
> This has been discussed to death several times, in several different paces, 
> and with no clear resolution or consensus, so I'm going to make an executive 
> decision:
>
> The coding style stays as-is. Braces are required. Please ensure that all 
> patches follow the coding style. There may be exceptions, but there should be 
> a *good* reason for deviation.
>
>
> If there are real problems or ambiguities in the coding style then I am 
> willing to consider fixing it. This particular change meets neither criteria.
>
> By picking a single coding style we've pretty much guaranteed that most people 
> will disagree with some of it. IMO consistency is more important.
>   

I agree 100%.

Regards,

Anthony Liguori

> Paul
>
>
>