From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Get coding style closer to the real world
Date: Sat, 05 Dec 2009 19:33:39 +0200 [thread overview]
Message-ID: <4B1A9973.8090305@redhat.com> (raw)
In-Reply-To: <4B198D96.6090407@codemonkey.ws>
On 12/05/2009 12:30 AM, Anthony Liguori wrote:
> Paul Brook wrote:
>> On Monday 30 November 2009, Alexander Graf wrote:
>>> Currently we have this stupid role of disallowing:
>>>
>>> if (r)
>>> break;
>>
>> This has been discussed to death several times, in several different
>> paces, and with no clear resolution or consensus, so I'm going to
>> make an executive decision:
>>
>> The coding style stays as-is. Braces are required. Please ensure that
>> all patches follow the coding style. There may be exceptions, but
>> there should be a *good* reason for deviation.
>>
>>
>> If there are real problems or ambiguities in the coding style then I
>> am willing to consider fixing it. This particular change meets
>> neither criteria.
>>
>> By picking a single coding style we've pretty much guaranteed that
>> most people will disagree with some of it. IMO consistency is more
>> important.
>
> I agree 100%.
+1'ed, and I note that although brace-happy code looks more cluttered it
is a bit safer and produces cleaner patches.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-12-05 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 21:55 [Qemu-devel] [PATCH] Get coding style closer to the real world Alexander Graf
2009-12-01 9:39 ` Markus Armbruster
2009-12-04 17:47 ` Paul Brook
2009-12-04 22:30 ` Anthony Liguori
2009-12-05 17:33 ` Avi Kivity [this message]
2009-12-04 23:47 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1A9973.8090305@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).