From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] kvm: x86: Fix initial kvm_has_msr_star
Date: Sun, 06 Dec 2009 17:12:52 +0200 [thread overview]
Message-ID: <4B1BC9F4.2030008@redhat.com> (raw)
In-Reply-To: <4B1BC4EC.90704@web.de>
On 12/06/2009 04:51 PM, Jan Kiszka wrote:
> KVM_GET_MSR_INDEX_LIST returns -E2BIG when the provided space is too
> small for all MSRs. But this is precisely the error we trigger with the
> initial request in order to obtain that size. Do not fail in that case.
>
> This caused a subtle corruption of the guest state as MSR_STAR was not
> properly saved/restored. The corruption became visible with latest kvm
> optimizing the MSR updates.
>
Strong ack. Anthony, please apply ASAP. This is worthy of a 0.11.2, IMO.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-12-06 15:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 14:51 [Qemu-devel] [PATCH] kvm: x86: Fix initial kvm_has_msr_star Jan Kiszka
2009-12-06 14:54 ` [Qemu-devel] [FOR 0.12][FOR 0.11][PATCH] " Jan Kiszka
2009-12-06 15:12 ` Avi Kivity [this message]
2009-12-07 8:12 ` [Qemu-devel] Re: [PATCH] " Avi Kivity
2009-12-07 8:24 ` Jan Kiszka
2009-12-07 8:42 ` Avi Kivity
2009-12-07 14:47 ` Anthony Liguori
2009-12-07 16:31 ` Avi Kivity
2009-12-07 16:33 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1BC9F4.2030008@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).